On Tue, Sep 26, 2023 at 09:13:17AM +0300, Tony Lindgren wrote: > We now get errors on system suspend if no_console_suspend is set as > reported by Thomas. The errors started with commit 20a41a62618d ("serial: > 8250_omap: Use force_suspend and resume for system suspend"). > > Let's fix the issue by checking for console_suspend_enabled in the system > suspend and resume path. > > Note that with this fix the checks for console_suspend_enabled in > omap8250_runtime_suspend() become useless. We now keep runtime PM usage > count for an attached kernel console starting with commit bedb404e91bb > ("serial: 8250_port: Don't use power management for kernel console"). ... Btw, how close are we to getting rid the pm_runtime_irq_safe() call? -- With Best Regards, Andy Shevchenko