On Fri, Sep 22, 2023 at 11:19:27AM +0200, Greg KH wrote: > On Thu, Sep 21, 2023 at 11:29:14PM +0200, Greg KH wrote: > > On Thu, Sep 21, 2023 at 10:13:33PM +0100, Cameron Williams wrote: > > > Add support for the rest of the Brainboxes range of serial cards, > > > except the 3-port variants as there is no suitable configuration > > > in this driver. > > > > > > - The pci_ids.h file has been updated to define each card's ID, cleaner > > > than using the raw ID. > > > > That's not happening in this patch, are you sure you got this correct? > > And where are patches 1-3 of this series? > Patches 1 to 3 were cc'd to the LKML [1][2][3]. Please disregard this patch series. Bjorn [maintainer of the PCI subsystem] has declined the pci_ids.h update so I will have to v2 this series using raw hex IDs. I guess thats what I get for doing kernel work without putting in enough time to check everything :(. Sorry for the mess. With regard to the 8250_pci.c file in particular, should I split each change into its own commit? I just want to avoid merge conflicts, and making all the changes in one commit made more sense to me but rules are rules, so I will follow them to get these devices supported. I'm still sort of new to patching like this so sorry for any mistakes :(. [1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ [2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ [3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Thanks Cameron. > thanks, > > greg k-h
