RE: [PATCH] Revert "tty: serial: fsl_lpuart: Fix the wrong RXWATER setting for rx dma case"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Robert Hodaszi <robert.hodaszi@xxxxxxxx>
> Sent: 2023年6月8日 18:15
> To: Sherry Sun <sherry.sun@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx;
> jirislaby@xxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Revert "tty: serial: fsl_lpuart: Fix the wrong RXWATER
> setting for rx dma case"
> 
> On 2023. 06. 08. 11:58, Sherry Sun wrote:
> > Oh, maybe LS1028 use the old IP version LPUART.
> > If this is the case, I suggest that you can set the rx_watermark of ls1028 to 0.
> >
> > static const struct lpuart_soc_data ls1028a_data = {
> >     .devtype = LS1028A_LPUART,
> >     .iotype = UPIO_MEM32,
> >     .rx_watermark = 0,
> > };
> >
> > Best Regards
> > Sherry
> 
> Ok, that should work in my case, as that's basically the same as reverting the
> patch. And I'm not losing anything on non-DMA case, as DMA is always used.
> 
> But the other platforms should be fixed as well, as it is a global issue across
> platforms using DMA with LPUART. So please push up then your previous
> patch with RXIDEN for platforms supporting that.
> 
Yes, the RXIDEN patch has already been upstreamed, you can check the latest kernel.

Best Regards
Sherry




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux