> > @@ -1767,6 +1775,7 @@ static void gsm_control_negotiation(struct gsm_mux *gsm, unsigned int cr,
> > } else {
> > if (debug & DBG_ERRORS)
> > pr_info("%s PN in invalid state\n", __func__);
> > + gsm->open_error++;
> > }
>
> I'd use the "rollback" pattern here for all these and goto open_failed;
> + do the open_error increment there only once.
True, that would be a more elegant way to handle this. However, it does
more than just adding this counter. Therefore, I would prefer to do this
in a later cleanup.
...
> In general, the changelog could be more verbose about state machine
> states, message names which imply that the error is happening during
> "opening" phase/state.
I will add a more detailed description.
Best regards,
Daniel Starke
