On Thu, Mar 2, 2023 at 9:01 AM Stefan Wahren <stefan.wahren@xxxxxxxx> wrote: > > Hi Saravana, > > Am 02.03.23 um 03:35 schrieb Saravana Kannan: > > This allow fw_devlink to do dependency tracking for serdev devices. > > > > Reported-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > Link: https://lore.kernel.org/lkml/03b70a8a-0591-f28b-a567-9d2f736f17e5@xxxxxxxxx/ > > Cc: Stefan Wahren <stefan.wahren@xxxxxxxx> > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > since this fixes an issue on Raspberry Pi 4, shouldn't this be mentioned > in the commit message and providing a Fixes tag? So RPi 4 was never creating a device links between serdev devices and their consumers. The error message was just a new one I added and we are noticing and catching the fact that serdev wasn't setting fwnode for a device. I'm also not sure if I can say this commit "Fixes" an issue in serdev core because when serdev core was written, fw_devlink wasn't a thing. Once I add Fixes, people will start pulling this into stable branches/other trees where I don't think this should be pulled into older stable branches. -Saravana > > Thanks > Stefan > > > --- > > Florian, > > > > Can you give it a shot and a tested-by please? > > > > -Saravana > > > > drivers/tty/serdev/core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c > > index aa80de3a8194..678014253b7b 100644 > > --- a/drivers/tty/serdev/core.c > > +++ b/drivers/tty/serdev/core.c > > @@ -534,7 +534,7 @@ static int of_serdev_register_devices(struct serdev_controller *ctrl) > > if (!serdev) > > continue; > > > > - serdev->dev.of_node = node; > > + device_set_node(&serdev->dev, of_fwnode_handle(node)); > > > > err = serdev_device_add(serdev); > > if (err) {
