On Tue, Dec 27, 2022 at 10:32:25AM +0100, Christina Quast wrote: > Hi Johan! > > Thanks for your review. I added this change, because that was GKH's > comment for the struct ft260_configure_uart_request in e previous > review of the commit: > > And as this is a structure that comes from the device, you should be > using __u8 and friends. > > So you are sure I should remove this change from the patchset? We want > to continue using u8? Yes, I believe Greg is mistaken here. He may prefer that style for some reason, but there's really no need to go about changing existing drivers to use __u8 for something which is not shared with user space. Side note: your mailer seems to be sending mails with HTML which will be rejected by the mailing lists. > On 12/27/22 09:45, Johan Hovold wrote: > > On Mon, Dec 26, 2022 at 06:15:49PM +0100, Christina Quast wrote: > >> Structures that come from a device should use __u8 instead of u8 > >> for their elements. Therefore change all elements in the HID report > >> structs from u8 to __u8. > > No, this is not correct. You only need to use __u8 in header files that > > are shared with user space. Johan
