Structures that come from a device should use __u8 instead of u8 for their elements. Therefore change all elements in the HID report structs from u8 to __u8. Signed-off-by: Christina Quast <contact@xxxxxxxxxxxxxxxxxx> --- drivers/hid/hid-ft260.c | 92 ++++++++++++++++++++--------------------- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index a67051f379a3..c2d1ded4a86b 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -137,93 +137,93 @@ enum { /* Feature In reports */ struct ft260_get_chip_version_report { - u8 report; /* FT260_CHIP_VERSION */ - u8 chip_code[4]; /* FTDI chip identification code */ - u8 reserved[8]; + __u8 report; /* FT260_CHIP_VERSION */ + __u8 chip_code[4]; /* FTDI chip identification code */ + __u8 reserved[8]; } __packed; struct ft260_get_system_status_report { - u8 report; /* FT260_SYSTEM_SETTINGS */ - u8 chip_mode; /* DCNF0 and DCNF1 status, bits 0-1 */ - u8 clock_ctl; /* 0 - 12MHz, 1 - 24MHz, 2 - 48MHz */ - u8 suspend_status; /* 0 - not suspended, 1 - suspended */ - u8 pwren_status; /* 0 - FT260 is not ready, 1 - ready */ - u8 i2c_enable; /* 0 - disabled, 1 - enabled */ - u8 uart_mode; /* 0 - OFF; 1 - RTS_CTS, 2 - DTR_DSR, */ + __u8 report; /* FT260_SYSTEM_SETTINGS */ + __u8 chip_mode; /* DCNF0 and DCNF1 status, bits 0-1 */ + __u8 clock_ctl; /* 0 - 12MHz, 1 - 24MHz, 2 - 48MHz */ + __u8 suspend_status; /* 0 - not suspended, 1 - suspended */ + __u8 pwren_status; /* 0 - FT260 is not ready, 1 - ready */ + __u8 i2c_enable; /* 0 - disabled, 1 - enabled */ + __u8 uart_mode; /* 0 - OFF; 1 - RTS_CTS, 2 - DTR_DSR, */ /* 3 - XON_XOFF, 4 - No flow control */ - u8 hid_over_i2c_en; /* 0 - disabled, 1 - enabled */ - u8 gpio2_function; /* 0 - GPIO, 1 - SUSPOUT, */ + __u8 hid_over_i2c_en; /* 0 - disabled, 1 - enabled */ + __u8 gpio2_function; /* 0 - GPIO, 1 - SUSPOUT, */ /* 2 - PWREN, 4 - TX_LED */ - u8 gpioA_function; /* 0 - GPIO, 3 - TX_ACTIVE, 4 - TX_LED */ - u8 gpioG_function; /* 0 - GPIO, 2 - PWREN, */ + __u8 gpioA_function; /* 0 - GPIO, 3 - TX_ACTIVE, 4 - TX_LED */ + __u8 gpioG_function; /* 0 - GPIO, 2 - PWREN, */ /* 5 - RX_LED, 6 - BCD_DET */ - u8 suspend_out_pol; /* 0 - active-high, 1 - active-low */ - u8 enable_wakeup_int; /* 0 - disabled, 1 - enabled */ - u8 intr_cond; /* Interrupt trigger conditions */ - u8 power_saving_en; /* 0 - disabled, 1 - enabled */ - u8 reserved[10]; + __u8 suspend_out_pol; /* 0 - active-high, 1 - active-low */ + __u8 enable_wakeup_int; /* 0 - disabled, 1 - enabled */ + __u8 intr_cond; /* Interrupt trigger conditions */ + __u8 power_saving_en; /* 0 - disabled, 1 - enabled */ + __u8 reserved[10]; } __packed; struct ft260_get_i2c_status_report { - u8 report; /* FT260_I2C_STATUS */ - u8 bus_status; /* I2C bus status */ + __u8 report; /* FT260_I2C_STATUS */ + __u8 bus_status; /* I2C bus status */ __le16 clock; /* I2C bus clock in range 60-3400 KHz */ - u8 reserved; + __u8 reserved; } __packed; /* Feature Out reports */ struct ft260_set_system_clock_report { - u8 report; /* FT260_SYSTEM_SETTINGS */ - u8 request; /* FT260_SET_CLOCK */ - u8 clock_ctl; /* 0 - 12MHz, 1 - 24MHz, 2 - 48MHz */ + __u8 report; /* FT260_SYSTEM_SETTINGS */ + __u8 request; /* FT260_SET_CLOCK */ + __u8 clock_ctl; /* 0 - 12MHz, 1 - 24MHz, 2 - 48MHz */ } __packed; struct ft260_set_i2c_mode_report { - u8 report; /* FT260_SYSTEM_SETTINGS */ - u8 request; /* FT260_SET_I2C_MODE */ - u8 i2c_enable; /* 0 - disabled, 1 - enabled */ + __u8 report; /* FT260_SYSTEM_SETTINGS */ + __u8 request; /* FT260_SET_I2C_MODE */ + __u8 i2c_enable; /* 0 - disabled, 1 - enabled */ } __packed; struct ft260_set_uart_mode_report { - u8 report; /* FT260_SYSTEM_SETTINGS */ - u8 request; /* FT260_SET_UART_MODE */ - u8 uart_mode; /* 0 - OFF; 1 - RTS_CTS, 2 - DTR_DSR, */ + __u8 report; /* FT260_SYSTEM_SETTINGS */ + __u8 request; /* FT260_SET_UART_MODE */ + __u8 uart_mode; /* 0 - OFF; 1 - RTS_CTS, 2 - DTR_DSR, */ /* 3 - XON_XOFF, 4 - No flow control */ } __packed; struct ft260_set_i2c_reset_report { - u8 report; /* FT260_SYSTEM_SETTINGS */ - u8 request; /* FT260_SET_I2C_RESET */ + __u8 report; /* FT260_SYSTEM_SETTINGS */ + __u8 request; /* FT260_SET_I2C_RESET */ } __packed; struct ft260_set_i2c_speed_report { - u8 report; /* FT260_SYSTEM_SETTINGS */ - u8 request; /* FT260_SET_I2C_CLOCK_SPEED */ + __u8 report; /* FT260_SYSTEM_SETTINGS */ + __u8 request; /* FT260_SET_I2C_CLOCK_SPEED */ __le16 clock; /* I2C bus clock in range 60-3400 KHz */ } __packed; /* Data transfer reports */ struct ft260_i2c_write_request_report { - u8 report; /* FT260_I2C_REPORT */ - u8 address; /* 7-bit I2C address */ - u8 flag; /* I2C transaction condition */ - u8 length; /* data payload length */ - u8 data[FT260_WR_DATA_MAX]; /* data payload */ + __u8 report; /* FT260_I2C_REPORT */ + __u8 address; /* 7-bit I2C address */ + __u8 flag; /* I2C transaction condition */ + __u8 length; /* data payload length */ + __u8 data[FT260_WR_DATA_MAX]; /* data payload */ } __packed; struct ft260_i2c_read_request_report { - u8 report; /* FT260_I2C_READ_REQ */ - u8 address; /* 7-bit I2C address */ - u8 flag; /* I2C transaction condition */ + __u8 report; /* FT260_I2C_READ_REQ */ + __u8 address; /* 7-bit I2C address */ + __u8 flag; /* I2C transaction condition */ __le16 length; /* data payload length */ } __packed; struct ft260_input_report { - u8 report; /* FT260_I2C_REPORT or FT260_UART_REPORT */ - u8 length; /* data payload length */ - u8 data[2]; /* data payload */ + __u8 report; /* FT260_I2C_REPORT or FT260_UART_REPORT */ + __u8 length; /* data payload length */ + __u8 data[2]; /* data payload */ } __packed; static const struct hid_device_id ft260_devices[] = { -- 2.35.1