On Mon, Nov 07, 2022 at 03:40:41PM +0300, Dan Carpenter wrote: > New smatch warnings: > drivers/tty/serial/8250/8250_omap.c:825 omap8250_rs485_config() warn: bitwise AND condition is false here [...] > vim +825 drivers/tty/serial/8250/8250_omap.c [...] > 801954d1210a89 Lukas Wunner 2022-10-16 @825 if (priv->mdr1 & UART_OMAP_MDR1_16X_MODE) > > This should be: > > if (priv->mdr1 == UART_OMAP_MDR1_16X_MODE) Thanks for the heads-up Dan, I've just submitted a fix: https://lore.kernel.org/linux-serial/7d5b04da13d89b8708b9543a0b125f2b6062a77b.1667977259.git.lukas@xxxxxxxxx/ As always your reports are greatly appreciated. Lukas
