On Thu, Jul 07, 2022 at 05:52:35PM +0200, Marek Behún wrote: > On Thu, 7 Jul 2022 17:10:42 +0200 > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Thu, Jul 07, 2022 at 04:53:51PM +0200, Marek Behún wrote: > > > From: Pali Rohár <pali@xxxxxxxxxx> > > > > > > On failure to set new baudrate, reset baudrate to the previous value > > > (as is done by other serial drivers) instead of resetting to 9600. > > > > Where is it mandated that this is correct? Why not keep the existing > > functionality? Did you just break systems that tried to set invalid > > values and ended up with 9600 as a default? > > Pali says all other drivers keep previous value on failure. He got > frustrated when working with FTDI devices because they behaved > differently. That's fine, but again, you are changing user-visible behavior here, so you need a real justification for it and be aware that it might break people's workflow. thanks, greg k-h
