Re: [PATCH 4/7] USB: serial: ftdi_sio: Do not reset baudrate to 9600 on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 7 Jul 2022 17:10:42 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, Jul 07, 2022 at 04:53:51PM +0200, Marek Behún wrote:
> > From: Pali Rohár <pali@xxxxxxxxxx>
> > 
> > On failure to set new baudrate, reset baudrate to the previous value
> > (as is done by other serial drivers) instead of resetting to 9600.  
> 
> Where is it mandated that this is correct?  Why not keep the existing
> functionality?  Did you just break systems that tried to set invalid
> values and ended up with 9600 as a default?

Pali says all other drivers keep previous value on failure. He got
frustrated when working with FTDI devices because they behaved
differently.

> What changed to make this a new requirement?
> 
> thanks,
> 
> greg k-h





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux