Re: [PATCH v4 7/9] serial: 8250: dw: Add support for DMA flow controlling devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 01, 2022 at 01:56:49PM +0300, Ilpo Järvinen wrote:
> On Wed, 30 Mar 2022, Miquel Raynal wrote:

...

> > +			writel(0, p->membase + RZN1_UART_RDMACR);
> > +			writel(1, p->membase + DW_UART_DMASA);
> 
> Currently there is serial_out(), dw8250_writel_ext(), and a few writel()s 
> too for writing to registers. It would be nice to move towards more 
> homogeneous approach rather than adding more writel()s.

Actually a good catch!

> I suggest dw8250_writel_ext() is moved to dwlib.h. Then it could be used 
> here (and dw8250_readl_ext() too should be moved but IIRC there wasn't 
> any reads added by this series).

I agree that for the sake of symmetry it's good to move both.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux