On Tue, Mar 29, 2022 at 10:10:49AM +0200, Miquel Raynal wrote: > andy.shevchenko@xxxxxxxxx wrote on Fri, 18 Mar 2022 12:51:29 +0200: > > On Thu, Mar 17, 2022 at 9:56 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: ... > > > +#include <linux/clk.h> > > > > I have mentioned forward declarations. > > Why do you want forward declarations more than includes? Because they will speed up the kernel build and avoid dirtifying the namespace (less possible collisions). > > So, this can be simply replaced by > > > > struct clk; > > > > > +#include <linux/notifier.h> > > > +#include <linux/workqueue.h> > > And why these two should remain but reset and clk be replaced? Because these one are being used, clk and reset are not (the pointers are opaque from the point of view of this header). > > > +#include <linux/reset.h> > > > > Ditto. > > > > struct reset_control; > > > > On top of that, please keep them ordered. > > > > Otherwise it looks good to me. -- With Best Regards, Andy Shevchenko
