On Thu, Mar 17, 2022 at 9:56 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > This structure needs to be reused from dwlib, so let's move it into a > shared header. There is no functional change. ... > #include <linux/types.h> > +#include <linux/clk.h> I have mentioned forward declarations. So, this can be simply replaced by struct clk; > +#include <linux/notifier.h> > +#include <linux/workqueue.h> > +#include <linux/reset.h> Ditto. struct reset_control; On top of that, please keep them ordered. Otherwise it looks good to me. -- With Best Regards, Andy Shevchenko
