On Tue, Feb 15, 2022 at 07:02:57AM +0100, Jiri Slaby wrote: > On 15. 02. 22, 6:55, Jiri Slaby wrote: > > On 15. 02. 22, 3:00, Qing Wang wrote: > > > From: Wang Qing <wangqing@xxxxxxxx> > > > > > > pci_get_slot() increases its reference count, the caller must > > > decrement the reference count by calling pci_dev_put() Wang, thank you for the report! ... > > What about the "return -ENODEV" few lines above? > > On the top of that, the code stores the pointer to the dev: > param->dma_dev = &dma_dev->dev; > > So we should likely put the device in ->exit(), not ->setup(). I think I may fix all these and send a new version. -- With Best Regards, Andy Shevchenko
