Re: [PATCH] tty: serial: 8250: add missing pci_dev_put() before return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15. 02. 22, 3:00, Qing Wang wrote:
From: Wang Qing <wangqing@xxxxxxxx>

pci_get_slot() increases its reference count, the caller must
decrement the reference count by calling pci_dev_put()

Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
---
  drivers/tty/serial/8250/8250_lpss.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
index d3bafec..57e462f
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -149,6 +149,8 @@ static int byt_serial_setup(struct lpss8250 *lpss, struct uart_port *port)
  	/* Disable TX counter interrupts */
  	writel(BYT_TX_OVF_INT_MASK, port->membase + BYT_TX_OVF_INT);
+ pci_dev_put(dma_dev);


What about the "return -ENODEV" few lines above?

  	return 0;
  }


--
js
suse labs



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux