On Mon, Jan 17, 2022 at 12:06:31AM +0100, Pavel Pisa wrote: > Dear Wander and Greg, > > [resend on base of email-bot of Greg Kroah-Hartman's inbox] > > I have noticed that you have sent enhancements > to the TTY layer. > > I have worked on architecture of automotive LIN-bus > support for Linux UARTs. The SocketCAN API was idea > of Oliver Hartkopp and we have designed internals > to implement actual protocol. Rostislav Lisovy > was main author at our university in 2011. The code > has been used and is used by more people and I have > helped its integration to local Volkswagen subsidiary > projects. I have helped to maintain it for years > even that I have actually no use for it or contract. > But is seems usable... > > I am not sure if it can reach quality standards > for mainline but I have tried to consolidate > many forks and copies from our original GIT > server which can be found on GitHub and united > project under > > https://github.com/lin-bus > > Kernel part - slLIN TTY discipline - can be found there > > https://github.com/lin-bus/linux-lin/tree/master/sllin So it's just a 2000 line kernel module? That should be easy to turn into a patch and submit for review, right? Odds are it can be made much smaller based on an initial glance at it. Review comments can help show what to do. > Documentation > > https://github.com/lin-bus/linux-lin/wiki/ > > The main obstacle to have version which can be used > with different UARTs seamlessly is missing internal low > level kernel API which would allow to control Rx trig > level. > > I have not checked your changes yet but I would be happy > if some API is available for this control. Please see > issue > > https://github.com/lin-bus/linux-lin/issues/13 > > Please suggest where to discuss the proposal/solutions > or if you plan to implement something like that. Discuss it here by submitting patches please. Links to random github repos do not do much as we can do nothing with them, sorry. thanks, greg k-h
