On Wed, Nov 17, 2021 at 10:46:35AM +0530, Shubhrajyoti Datta wrote: > The commit b44b96a060f3((uartlite: Adding a kernel parameter for the number of uartlites) > states > "The uartlite is used by FPGAs that support a basically unlimited number > of uarts so limiting it at 16 dosn't make sense as users might need more > than that." > the commit also said that number should be unlimited. However it set the > default to 1 instead of 16.The original 16 written in driver should be > quite reasonable default to cover most of the cases. > > So change the default number of uarts back to 16. > > Fixes: b44b96a060f3 (uartlite: Adding a kernel parameter for the number of uartlites) > Reviewed-by: Michal Simek <michal.simek@xxxxxxxxxx> > Cc: Sam Povilus <kernel.development@xxxxxxxx> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> > --- > v2: Update the commit message. > > drivers/tty/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 131a6a587acd..1254b523ca9a 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -531,7 +531,7 @@ config SERIAL_UARTLITE_NR_UARTS > int "Maximum number of uartlite serial ports" > depends on SERIAL_UARTLITE > range 1 256 > - default 1 > + default 16 > help > Set this to the number of uartlites in your system, or the number > you think you might implement. If you know you want to increase the number, just do so in your configuration file, right? If not, no specific number is going to be "correct", so why do you have a number at all in here? Shouldn't this all "just work" and not need to be pre-allocated by the driver at build time? I'd much rather prefer to take a change that removes this build time restriction entirely. thanks, greg k-h
