Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sherry Sun <sherry.sun@xxxxxxx>
Subject: Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()
From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 24 Nov 2021 10:59:05 +0100
Cc: jirislaby@xxxxxxxxxx, u.kleine-koenig@xxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-imx@xxxxxxx
In-reply-to: <20211123105122.7913-1-sherry.sun@nxp.com>
References: <20211123105122.7913-1-sherry.sun@nxp.com>

On Tue, Nov 23, 2021 at 06:51:22PM +0800, Sherry Sun wrote:
> From: Fugang Duan <fugang.duan@xxxxxxx>
> 
> Disable the UCR4_OREN bit in .stop_rx() before the uart receiver is disabled
> maybe better than in the .shutdown() function.

Why is it better?  What does this "fix"?

thanks,

greg k-h

Follow-Ups:
- RE: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()
  - From: Sherry Sun

References:
- [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()
  - From: Sherry Sun

Prev by Date: Re: [PATCH 1/1] tty: serial: uartlite: allow 64 bit address
Next by Date: Re: [PATCH v2] uartlite: Update the default for the SERIAL_UARTLITE_NR_UARTS
Previous by thread: Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()
Next by thread: RE: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]

Powered by Linux