On Wed, Nov 17, 2021 at 5:52 AM Jay Dolan <jay.dolan@xxxxxxxxxxx> wrote: > On 11/16/21 7:34 AM, Andy Shevchenko wrote: > > On Sun, Nov 14, 2021 at 8:40 PM Jay Dolan <jay.dolan@xxxxxxxxxxx> wrote: > >> > >> A series patches to address three issues one customer managed to hit all at once. > >> > >> 1) Rewrite pericom_do_set_divisor() to always calc divisor and to use the > >> uartclk instead of a hard coded value. Always calculate divisor without passing > >> control to serial8250_do_set_divisor() > >> Tested with 14.7456 and 24 MHz crystals > >> > >> 2) Re-enable higher baud rates on Pericom chips. > >> serial8250_get_baud_rate() added range checking, but Pericom chips have a wider > >> range than what is being enforced. Make use of UPF_MAGIC_MULTIPLIER. > >> Tested with 14.7456 and 24 MHz crystals > >> > >> 3) Fourth port not being setup correctly on some Pericom chips. > >> Fix entries in pci_serial_quirks array > > > > Can we start from splitting Pericom to its own file, please? > > > > See my initial work here [1]. And I believe you may do a better job > > than me since you have access to many variants of the hardware. > > > > [1]: https://gitlab.com/andy-shev/next/-/commit/71fdb8b5d857691031f566daebb1e850b106f46a > That would be great. Breaking it out has been on my wish list for a > while, but I doubt I was ever going to have time. I'm not familiar with > GitLab. Is there a way for me to fetch this branch or should I just > apply the diff I downloaded? I will prepare a patch series where I take your patches and incorporate mine in between. Stay tuned! > > (As a side note: > > https://gitlab.com/andy-shev/next/-/commit/ac0dc993fa35b5e2fe67e967b6a687b2e47d0edd) -- With Best Regards, Andy Shevchenko
