On Tue, Oct 5, 2021 at 11:49 AM LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@xxxxxxxxxxxxx> wrote: > On Wed, 2021-09-29 at 19:48 +0300, Andy Shevchenko wrote: ... > > Please, do not add this to 8250_pci.c. Use separate quirk driver as > > it's done > > in plenty of examples: > > > > 8250_lpss.c, 8250_mid.c, 8250_exar.c, ... > > Thanks for pointing the examples. I have looked into these examples and > the required functionality can be achieved with a separate driver. But > I would like to know the reason for not adding this to 8250_pci.c. Maintainability. And we may check, btw, the LOC difference when you will be ready with a separate driver. In some cases it would even be a good win. -- With Best Regards, Andy Shevchenko
