Classification: Public
Hi JS,
Got the function opening change and will do it.
But could not understand the meaning which you are referring by mangled lines.
Please can you explain the issue for one place so that I will do for all
Thank you.
On 27. 08. 21, 18:32, Sathish Kumar Balasubramaniam -ERS, HCL Tech wrote:
> +static void chromite_serial_set_termios(struct uart_port *port,
> + struct ktermios *termios,
> + struct ktermios *old) {
> + struct chromite_serial_port *csp = port_to_chromite_serial_port(port);
> + unsigned long flags;
> + int rate;
> +
> + if ((termios->c_cflag & CSIZE) != CS8)
> + dev_err_once(csp->port.dev, "only 8-bit words supported\n");
> + if (termios->c_cflag & CSTOPB)
> + dev_err_once(csp->port.dev, "only 1 stop-bit is supported\n");
> + if (termios->c_iflag & (INPCK | PARMRK))
> + dev_err_once(csp->port.dev, "parity checking not supported\n");
> + if (termios->c_iflag & BRKINT)
> + dev_err_once(csp->port.dev, "BREAK detection not
> + supported\n");
Many mangled lines like this. Please fix these up in v2. And also use checkpatch. The function-opening { above should be on a separate line (on many locations).
thanks,
--
js
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________
