Re: [PATCH] tty: serial: UART driver for RISC-V based Chromite SoC family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27. 08. 21, 18:32, Sathish Kumar Balasubramaniam -ERS, HCL Tech wrote:
+static void chromite_serial_set_termios(struct uart_port *port,
+                                               struct ktermios *termios,
+                                               struct ktermios *old) {
+       struct chromite_serial_port *csp = port_to_chromite_serial_port(port);
+       unsigned long flags;
+       int rate;
+
+       if ((termios->c_cflag & CSIZE) != CS8)
+               dev_err_once(csp->port.dev, "only 8-bit words supported\n");
+       if (termios->c_cflag & CSTOPB)
+               dev_err_once(csp->port.dev, "only 1 stop-bit is supported\n");
+       if (termios->c_iflag & (INPCK | PARMRK))
+               dev_err_once(csp->port.dev, "parity checking not supported\n");
+       if (termios->c_iflag & BRKINT)
+               dev_err_once(csp->port.dev, "BREAK detection not
+ supported\n");

Many mangled lines like this. Please fix these up in v2. And also use checkpatch. The function-opening { above should be on a separate line (on many locations).

thanks,
--
js



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux