Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jiri Slaby <jirislaby@xxxxxxxxxx>
Subject: Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 21 Jan 2021 09:46:58 -0800
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Oliver Giles <ohw.giles@xxxxxxxxx>, Robert Karszniewicz <r.karszniewicz@xxxxxxxxx>
In-reply-to: <ff6709dc-bb42-1e52-b348-c52036960bdd@kernel.org>
References: <20210121090020.3147058-1-gregkh@linuxfoundation.org> <20210121090020.3147058-2-gregkh@linuxfoundation.org> <ff6709dc-bb42-1e52-b348-c52036960bdd@kernel.org>

On Thu, Jan 21, 2021 at 3:02 AM Jiri Slaby <jirislaby@xxxxxxxxxx> wrote:
>
> n_hdlc_tty_read will return EOVERFLOW when size is 0, so this EFAULT is
> never propagated, if I am looking correctly? n_tty seems to be fine
> (returns zero for zeroed size).

I'll fix that up too.

Greg - same question - do you want an incremental patch, or just a new series?

              Linus

Follow-Ups:
- Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
  - From: Greg Kroah-Hartman

References:
- [PATCH 1/6] tty: implement write_iter
  - From: Greg Kroah-Hartman
- [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
  - From: Greg Kroah-Hartman
- Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
  - From: Jiri Slaby

Prev by Date: Re: [PATCH 1/6] tty: implement write_iter
Next by Date: Re: [PATCH 1/6] tty: implement write_iter
Previous by thread: Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
Next by thread: Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]