On 15. 12. 20, 1:29, Ji-Ze Hong (Peter Hong) wrote:
Hi,
Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道:
pdata->pid = chip;
+
+ pr_info("%s%s%s Fintek %s\n",
+ uart->port.dev ? dev_name(uart->port.dev) : "",
+ uart->port.dev ? ": " : "",
+ uart->port.name,
+ chip_name);
Drivers, if all goes well, should not print anything to the kernel log.
This isn't ok.
And even if it was, dev_info() would be the correct thing to do...
Maybe can transform pr_info() to dev_dbg() for debug usage ?
And even then, the newly introduced fintek_8250.chip_name is unused.
thanks,
--
js
