* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> [691231 23:00]: > Static analyzer can not see balanced locking if the lock is acquired and > released conditionally. > > context imbalance in 'uart_stop' - unexpected unlock > context imbalance in 'uart_start' - different lock contexts for basic block > context imbalance in 'uart_port_startup' - different lock contexts for basic block > context imbalance in 'uart_shutdown' - different lock contexts for basic block > context imbalance in 'uart_put_char' - different lock contexts for basic block > context imbalance in 'uart_write' - different lock contexts for basic block > context imbalance in 'uart_write_room' - different lock contexts for basic block > context imbalance in 'uart_chars_in_buffer' - different lock contexts for basic block > context imbalance in 'uart_flush_buffer' - different lock contexts for basic block > > Get rid of macros and implement their functionality in place. This will also > help to enable runtime PM in cleaner way later on. Nice, yeah this is needed to make PM runtime handling generic for serial_core.c. Patch works for me for my PM tests: Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx> Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>