On 04. 03. 20, 10:37, 唐彬 wrote: > I'm very happy for your replay. But I don't understand, in this > place ,it's function is to judge.You say 'the probe function is expected > to return a negative value in case of error'？But at the top or bottom > of the code here in mvebu_uart_probe()，there are a lot of judgments > that return negative numbers. How do you explain that? That's exactly the point. The function should return a negative value and PTR_ERR already returns a negative. That is, your patch is correct, but your commit message missed an explanation. thanks, -- js suse labs
