On 03. 03. 20, 8:13, tangbin wrote: > in this place,the right return should be > return PTR_ERR(),not return -PTR_ERR() One because missing. Like ", because PTR_ERR already returns a negative error and the probe function is expected to return a negative value in case of error." Acked-by: Jiri Slaby <jslaby@xxxxxxx> > Signed-off-by: tangbin <tangbin@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/tty/serial/mvebu-uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c > index c12a12556..4e9a59071 100644 > --- a/drivers/tty/serial/mvebu-uart.c > +++ b/drivers/tty/serial/mvebu-uart.c > @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev) > > port->membase = devm_ioremap_resource(&pdev->dev, reg); > if (IS_ERR(port->membase)) > - return -PTR_ERR(port->membase); > + return PTR_ERR(port->membase); > > mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart), > GFP_KERNEL); > -- js suse labs
