On Mon, Nov 18, 2019 at 08:31:44PM +0100, Richard Weinberger wrote: > ----- Ursprüngliche Mail ----- > > Von: "Miquel Raynal" <miquel.raynal@xxxxxxxxxxx> > > An: "richard" <richard@xxxxxx> > > CC: "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>, "Sudip Mukherjee" <sudipm.mukherjee@xxxxxxxxx>, "Kyungmin Park" > > <kyungmin.park@xxxxxxxxxxx>, "Vignesh Raghavendra" <vigneshr@xxxxxx>, "Jiri Slaby" <jslaby@xxxxxxxx>, "linux-kernel" > > <linux-kernel@xxxxxxxxxxxxxxx>, "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-serial" > > <linux-serial@xxxxxxxxxxxxxxx> > > Gesendet: Montag, 18. November 2019 20:22:57 > > Betreff: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning > > > Hi all, > > > > Richard Weinberger <richard@xxxxxx> wrote on Mon, 18 Nov 2019 13:47:50 > > +0100 (CET): > > > >> ----- Ursprüngliche Mail ----- > >> >> I was not sure if this should have been two different patch, but since > >> >> this will be fixing the same problem so it seems its better to have them > >> >> in a single patch. > >> >> > >> >> drivers/mtd/nand/onenand/Makefile | 2 +- > >> >> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0 > >> >> drivers/tty/serial/Makefile | 2 +- > >> >> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0 > >> >> 4 files changed, 2 insertions(+), 2 deletions(-) > >> >> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%) > >> >> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%) > >> > > >> > I can take this in the tty tree if the mtd maintainer gives an ack for > >> > it... > >> > >> Acked-by: Richard Weinberger <richard@xxxxxx> > > > > If it is not too late, I am not a big fan of the new naming which is > > rather not descriptive. Files in the onenand subdirectory are: > > * onenand_<something>.c for the base files > > * <vendor>.c for the vendors files (currently: omap2.c and samsung.c). > > Well, I'm fine with the naming either way. :-) If you want to rename the mtd driver later, that's fine, I'll take this for now for 5.5-rc1 and you all can bikeshed it for 5.5-final :) thanks, greg k-h