Hi,K-H, Thanks for review, my replies are inline: Signed-off-by: Morris Ku <saumah@xxxxxxxxx> --- 0004-Add-driver-for-SUNIX-serial-board.patch | 36 ++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 0004-Add-driver-for-SUNIX-serial-board.patch diff --git a/0004-Add-driver-for-SUNIX-serial-board.patch b/0004-Add-driver-for-SUNIX-serial-board.patch new file mode 100644 index 0000000..56909d2 --- /dev/null +++ b/0004-Add-driver-for-SUNIX-serial-board.patch @@ -0,0 +1,36 @@ >On Wed, Jul 24, 2019 at 07:26:47PM +0800, morrisku wrote: >> This patch add support for SUNIX serial board. >> >> Signed-off-by: morrisku <saumah@xxxxxxxxx> >I need a "real" name here, and on the From: line in order to ba able to >apply anything. Use whatever you sign legal documents with please. I will fix it. >> --- >> serial/Kconfig | 11 ++ >> serial/Makefile | 1 + >> serial/sunix_uart.c | 357 ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 369 insertions(+) >> create mode 100644 serial/sunix_uart.c >Why can't you just use the 8250_pci.c driver here instead of a whole >separate one? What does this hardware need that is so different that >you can not just add to the normal pci_boards[] array in that code? >If you can not do that, then you need to explain in great detail why >that is in the changelog comment in order for us to be able to accept >this code. SUNIX uses a mixture of bars and offsets, the first four ports use bar0,fifth to sixteenth ports use bar1, 8025_pci.c using different bars and offsets, fist port use bar0,port two use use bar0 + offset, but three to four ports use bar1 ,after port use bar2~bar5, can not just use 8250 existing code to set up our hardware, the configure method is not suitable for us, therefore, we separate one driver for SUNIX serial board. >thanks, >greg k-h -- 2.17.1
