On Wed, Jul 24, 2019 at 07:26:47PM +0800, morrisku wrote: > This patch add support for SUNIX serial board. > > Signed-off-by: morrisku <saumah@xxxxxxxxx> I need a "real" name here, and on the From: line in order to ba able to apply anything. Use whatever you sign legal documents with please. > --- > serial/Kconfig | 11 ++ > serial/Makefile | 1 + > serial/sunix_uart.c | 357 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 369 insertions(+) > create mode 100644 serial/sunix_uart.c Why can't you just use the 8250_pci.c driver here instead of a whole separate one? What does this hardware need that is so different that you can not just add to the normal pci_boards[] array in that code? If you can not do that, then you need to explain in great detail why that is in the changelog comment in order for us to be able to accept this code. thanks, greg k-h
