Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> writes:
> On Wed, Jun 26, 2019 at 05:11:30PM +0300, Sergey Organov wrote:
>> imx_set_termios() cleared RTS on every call, now fixed.
>
> Is this a real problem, or something you noticed by looking at the code?
> I think I already asked that in a previous round, if so this should at
> least be explained in more detail in the commit log.
Yes, it was real observed problem. Every call to set_termios from user
space (through tcsetattr() function) cleared RTS.
> Also please note that this is about the UCR2_CTS flag. (It is, isn't
> it? I don't understand it after staring at the code for a while.)
"CTS" in iMX terms means what everybody else calls "RTS"! Please notice
how they are used in the entire driver, e.g.:
if (mctrl & TIOCM_RTS) {
ucr2 |= UCR2_CTS;
> Assuming this is a real fix, it would be great if this patch came first
> in the series (i.e. before the cleanups) and would be more straight
> forward to understand.
I rather believe that pre-cleanups actually make the fix more
straightforward to understand.
Thanks!
-- Sergey
