On Wed, Jun 26, 2019 at 05:11:33PM +0300, Sergey Organov wrote:
> Called in only one place, for RS232, it only obscures things, as it
> doesn't go well with 2 similar named functions,
> imx_uart_rts_inactive() and imx_uart_rts_active(), that both are
> RS485-specific.
>
> Reviewed-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Tested-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Signed-off-by: Sergey Organov <sorganov@xxxxxxxxx>
> ---
> drivers/tty/serial/imx.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 171347d..a5e80a0 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -402,13 +402,6 @@ static void imx_uart_rts_inactive(struct imx_port *sport, u32 *ucr2)
> mctrl_gpio_set(sport->gpios, sport->port.mctrl);
> }
>
> -/* called with port.lock taken and irqs caller dependent */
> -static void imx_uart_rts_auto(struct imx_port *sport, u32 *ucr2)
> -{
> - if (*ucr2 & UCR2_CTS)
> - *ucr2 |= UCR2_CTSC;
> -}
> -
> /* called with port.lock taken and irqs off */
> static void imx_uart_start_rx(struct uart_port *port)
> {
> @@ -1598,8 +1591,10 @@ imx_uart_set_termios(struct uart_port *port, struct ktermios *termios,
> else
> imx_uart_rts_inactive(sport, &ucr2);
>
> - } else if (termios->c_cflag & CRTSCTS)
> - imx_uart_rts_auto(sport, &ucr2);
> + } else if (termios->c_cflag & CRTSCTS) {
> + if (ucr2 & UCR2_CTS)
> + ucr2 |= UCR2_CTSC;
> + }
At least before it was (somewhat) clear that this is about RTS and it
is about something automatic. So I don't like the patch.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
