Hello Russell,
On Fri, May 31, 2019 at 04:24:04PM +0100, Russell King wrote:
> As suggested by Uwe, add a note indicating that the modem control
> signals do not support interrupts, which precludes the driver from
> using mctrl_gpio_init().
>
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> ---
>
> Uwe, something like this?
>
> drivers/tty/serial/sa1100.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/sa1100.c b/drivers/tty/serial/sa1100.c
> index a6b4309b62fc..d7dbf0576be8 100644
> --- a/drivers/tty/serial/sa1100.c
> +++ b/drivers/tty/serial/sa1100.c
> @@ -949,6 +949,9 @@ static int sa1100_serial_resume(struct platform_device *dev)
> static int sa1100_serial_add_one_port(struct sa1100_port *sport, struct platform_device *dev)
> {
> sport->port.dev = &dev->dev;
> +
> + // GPIO driver does not support interrupts for these modem
> + // control signals, so the serial driver polls them.
> sport->gpios = mctrl_gpio_init_noauto(sport->port.dev, 0);
> if (IS_ERR(sport->gpios)) {
> int err = PTR_ERR(sport->gpios);
I would mention that because of this mctrl_gpio_init cannot be used.
(And I would have expected C-like comments).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
