Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> writes: > Hello Sergey, > > On Fri, May 31, 2019 at 09:17:02AM +0300, Sergey Organov wrote: >> Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> writes: >> >> > On Fri, May 31, 2019 at 07:52:51AM +0300, Sergey Organov wrote: >> >> My best reasoning was that DSR/ DTR is likely implemented the same as >> >> CTS/ RTS in the metal, and I found other drivers where both RTS and DSR >> >> are inverted, so I guessed it could be a remnant of old copy-paste. >> > >> > This is not a good enough reason to "fix" that. >> >> Yeah, I agree. I rather mostly kept it in the series not to forget about >> the issue. I should have said that in the comments, sorry. > > Then also sort this to the end of the series to allow clean application > of the patches you are sure about and mark the questionable patches as > RFC or RFT. I'm not sure we shouldn't actually fix it. Can we get help from NXP for clarification on the issue? I'm still 90% sure it's a bug. The rest of the series should apply clearly independent on this one, but I'll re-check anyway. -- Sergey