On 15.03.19 10:04, Andy Shevchenko wrote: > On Fri, Mar 15, 2019 at 12:41 AM Enrico Weigelt, metux IT consult > <info@xxxxxxxxx> wrote: >> >> Instead of fetching out data from a struct resource for passing >> it to devm_ioremap(), directly use devm_ioremap_resource() > > I don't see any advantage of this change. > See also below. I see that the whole story wasn't clear. Please see my reply to Greg, hope that clears it up a little bit. >> --- a/drivers/tty/serial/8250/8250_dw.c >> +++ b/drivers/tty/serial/8250/8250_dw.c >> @@ -526,7 +526,7 @@ static int dw8250_probe(struct platform_device *pdev) >> p->set_ldisc = dw8250_set_ldisc; >> p->set_termios = dw8250_set_termios; >> >> - p->membase = devm_ioremap(dev, regs->start, resource_size(regs)); >> + p->membase = devm_ioremap_resource(dev, regs); >> if (!p->membase) > > And how did you test this? devm_ioremap_resource() returns error > pointer in case of error. hmm, devm_ioremap_resource() does so, but devm_ioremap() does not ? I really didn't expect that. Thanks for pointing that out. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
