From: Li RongQing <lirongqing@xxxxxxxxx> when fail to open tty, tty is not in open status and not need to call close Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx> --- drivers/tty/serdev/serdev-ttyport.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index fa1672993b4c..bcc1e27d00de 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c @@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl) ret = tty->ops->open(serport->tty, NULL); if (ret) - goto err_close; + goto err_unlock; tty_unlock(serport->tty); @@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl) return 0; -err_close: - tty->ops->close(tty, NULL); err_unlock: tty_unlock(tty); tty_release_struct(tty, serport->tty_idx); -- 2.16.2