Hi, On Tue, Oct 16, 2018 at 7:11 AM Mukesh, Savaliya <msavaliy@xxxxxxxxxxxxxx> wrote: > > From: Mukesh Kumar Savaliya <msavaliy@xxxxxxxxxxxxxx> > > UART driver checks for the PM state and denies suspend if state is ACTIVE. > This makes UART to deny suspend when client keeps port open which is not > correct. Instead follow framework and obey suspend-resume callbacks. > > Signed-off-by: Mukesh Kumar Savaliya <msavaliy@xxxxxxxxxxxxxx> > --- > drivers/tty/serial/qcom_geni_serial.c | 36 ++++++----------------------------- > 1 file changed, 6 insertions(+), 30 deletions(-) Looks peachy. Getting rid of all that unnecessary code and moving away from the "no_irq" suspend op makes lots of sense to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
