Hi, On Tue, Oct 16, 2018 at 6:34 AM Mukesh, Savaliya <msavaliy@xxxxxxxxxxxxxx> wrote: > > From: Mukesh Kumar Savaliya <msavaliy@xxxxxxxxxxxxxx> > > UART driver checks for the PM state and denies suspend if state is ACTIVE. > This makes UART to deny suspend when client keeps port open which is not > correct. Instead follow framework and obey suspend-resume callbacks. > > Signed-off-by: Mukesh Kumar Savaliya <msavaliy@xxxxxxxxxxxxxx> > --- > drivers/tty/serial/qcom_geni_serial.c | 36 ++++++----------------------------- > 1 file changed, 6 insertions(+), 30 deletions(-) Looks like this patch was re-sent about an hour later with a different subject of ("tty: serial: qcom_geni_serial: Rectify UART suspend mechanism") at <https://lkml.kernel.org/r/1539699060-3055-1-git-send-email-msavaliy@xxxxxxxxxxxxxx>. The subject of the later patch seems better. I'll do my review there. -Doug