Re: [PATCH] serial: samsung: don't use "unused" uart_port struct member for tx/rx enable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

I don't feel confident to go mucking about in the Samsung serial
driver private_data setup (and I have no Samsung hardware to test
changes).  Is there someone here who is familiar with their hardware
and driver who can help?

Thanks,

Steve
On Thu, Oct 4, 2018 at 8:22 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 04, 2018 at 08:08:55AM -1000, Steve Sakoman wrote:
> > Replace with explicit samsung_tx_en and samsung_rx_en flags
>
> No, these should hang off of the private_data field, no driver-specific
> stuff should be in this structure.
>
> thanks,
>
> greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux