Hi Greg, I don't feel confident to go mucking about in the Samsung serial driver private_data setup (and I have no Samsung hardware to test changes). Is there someone here who is familiar with their hardware and driver who can help? Thanks, Steve On Thu, Oct 4, 2018 at 8:22 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Oct 04, 2018 at 08:08:55AM -1000, Steve Sakoman wrote: > > Replace with explicit samsung_tx_en and samsung_rx_en flags > > No, these should hang off of the private_data field, no driver-specific > stuff should be in this structure. > > thanks, > > greg k-h