Re: [PATCH] serial: samsung: don't use "unused" uart_port struct member for tx/rx enable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 04, 2018 at 11:22:03AM -0700, Greg KH wrote:
> On Thu, Oct 04, 2018 at 08:08:55AM -1000, Steve Sakoman wrote:
> > Replace with explicit samsung_tx_en and samsung_rx_en flags
> 
> No, these should hang off of the private_data field, no driver-specific
> stuff should be in this structure.

Or if you want to be really sneaky, just use that pointer as a bitfield
or char array :)



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux