On Tue, Jul 24, 2018 at 08:17:07PM +0300, Andy Shevchenko wrote: > On Sat, 2018-07-21 at 08:42 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 18, 2018 at 06:28:04PM +0300, Andy Shevchenko wrote: > > > Since we have port name stored in struct uart_port, we better to use > > > that one instead of open coding. > > > > > > This will make it one place source for easier maintenance or > > > modifications. > > > > > > While here, replace printk_ratelimited(KERN_INFO ) by > > > pr_info_ratelimited(). > > > It seems last printk() call in 8250_port.c. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > --- > > > drivers/tty/serial/8250/8250_core.c | 2 +- > > > drivers/tty/serial/8250/8250_port.c | 24 +++++++++++------------- > > > 2 files changed, 12 insertions(+), 14 deletions(-) > > > > This adds a build warning and it doesn't apply cleanly to the tree :( > > Hmm... > > Can you be more specific? > > I have took your tty-testing, added few kernel configuration parameters, > and cherry-picked this patch. No issues while cherry-pick, no new > warnings with make W=1. I think this was the other patch build warning, I missattributed it to this one :( So can you please resend this patch so I can queue it up? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
