Re: [PATCH v1 1/1] serial: 8250: Use cached port name directly in messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 18, 2018 at 06:28:04PM +0300, Andy Shevchenko wrote:
> Since we have port name stored in struct uart_port, we better to use
> that one instead of open coding.
> 
> This will make it one place source for easier maintenance or
> modifications.
> 
> While here, replace printk_ratelimited(KERN_INFO ) by pr_info_ratelimited().
> It seems last printk() call in 8250_port.c.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_core.c |  2 +-
>  drivers/tty/serial/8250/8250_port.c | 24 +++++++++++-------------
>  2 files changed, 12 insertions(+), 14 deletions(-)

This adds a build warning and it doesn't apply cleanly to the tree :(

Can you fix that up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux