serdev vs. sc16is7x2 - two tty ports per of_node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob et al.,

I'm looking at a board with a SPI-UART bridge SC16IS752 (sc16is7xx.c).
The driver exposes two serial ports ttySC0 and ttySC1 from one SPI slave
node, i.e. they have the same dev and thus of_node.

Am I seeing correctly that serdev currently assumes a 1:1 mapping
between DT node and serial port and can't deal with 1:n yet?

In particular core.c of_serdev_register_devices() seems to iterate over
all child nodes, checking only for a compatible string but not for a reg
property. I was considering to implement such a check, but it seems the
tty_port that has the line field to distinguish them is abstracted away
into the serdev-ttyport.c implementation, with no clean access from
core.c where all that magic happens. Backwards compatibility with
existing nodes without reg property is another concern.

Similarly core.c serdev_controller_remove() iterates over all child
devices and in serdev_remove_device() only checks for dev->type before
attemping to remove them.

Any suggestions what to do here?

Thanks,

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux