Hello,
Cc += Lukas Wunner and the imx guys
On Mon, Feb 19, 2018 at 10:24:15AM +0100, phil eichinger wrote:
> Only one of the two is really required, not both:
> * have_rtscts or
> * have_rtsgpio
>
> In imx_rs485_config() this is done correctly, so RS485 is working,
> just the error message is false.
>
> Signed-off-by: Phil Eichinger <phil@xxxxxxxxxxxxx>
Fixes: b8f3bff057b0 ("serial: imx: Support common rs485 binding for RTS polarity"
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
@Shawn + Fabio: Maybe we should add this driver (and the other imx
specifc drivers, too) to the IMX entry in MAINTAINERS?
> ---
> drivers/tty/serial/imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 1d7ca382bc12..a33c685af990 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -2093,7 +2093,7 @@ static int serial_imx_probe(struct platform_device *pdev)
> uart_get_rs485_mode(&pdev->dev, &sport->port.rs485);
>
> if (sport->port.rs485.flags & SER_RS485_ENABLED &&
> - (!sport->have_rtscts || !sport->have_rtsgpio))
> + (!sport->have_rtscts && !sport->have_rtsgpio))
Is this more clear when written as:
!(sport->have_rtscts || sport->have_rtsgpio)
? IMHO yes, but this might be subjective.
> dev_err(&pdev->dev, "no RTS control, disabling rs485\n");
>
> imx_rs485_config(&sport->port, &sport->port.rs485);
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
