On Thu, Jan 25, 2018 at 02:08:35PM +0200, Andy Shevchenko wrote: > On Wed, 2018-01-24 at 21:35 +0000, David Howells wrote: > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > Not tested at all. > > > Your patch doesn't say why or whether this causes userspace API > > breakage. Can > > you please include a patch description? > > This feature is considered deprecated for many years already. As you can > see by the change done here, there are only few drivers that still > support that. You still need to provide a proper commit message. And every serial driver currently supports this through serial core. Also it looks like you are changing the default speed for a couple of ftdi devices, which would need to be addressed. And you're removing deprecation warnings that we may want to keep around. I ripped out the alt_speed support from usb-serial last year, since that was indeed broken, but kept the custom divisor support in ftdi for now on purpose. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
