On Wed, Sep 20, 2017 at 02:33:47PM +0200, Clemens Gruber wrote: > Hi, > > On Tue, Sep 19, 2017 at 11:22:35AM +0200, Uwe Kleine-König wrote: > > On Fri, Sep 15, 2017 at 05:32:16PM +0200, Clemens Gruber wrote: > <snip> > > > Any idea how to reproduce it? Can you be more specific about the > > > situation with and without this patch? > > > > Something that you might be able to reproduce on your side: > > > > enable gpio tracing (i.e. > > echo 1 > /sys/kernel/debug/tracing/events/gpio/enable) > > > > and then do > > > > cat /dev/ttymxcX > > > > . For me this makes RTS toggle (while IMHO it shouldn't). > > Interesting. > > I see two gpio_value set 0 events, when I cat /dev/ttymxcX and Ctrl+C. > The function_graph tracer shows that the first one comes from > imx_set_termios (called by uart_change_speed, after imx_startup). > The second gpio_value set 0 event comes from imx_stop_tx, called by > imx_shutdown. > > Uwe: In your last mail, you wrote that rs485 works for you *now*. > What was the problem before? You said earlier that Ian's patch > did not fix the issues completely. My patch stack contains now (among others): serial: Add common rs485 device tree parsing function serial: imx: default to half duplex rs485 serial: imx: Use common rs485 device tree parsing function [RFC] serial: Don't mess with RTS if port is in RS485 mode [RFC] serial: Don't call .start_tx if there is nothing to be sent These were all sent to linux-serial. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
