Re: [PATCH RESEND] serial: imx: Update cached mctrl value when changing RTS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

now that rs485 works for me:

On Thu, Sep 14, 2017 at 01:11:33PM +0100, Ian Jamison wrote:
> UART core function uart_update_mctrl relies on a cached value of
> modem control lines. This was used but not updated by local RTS
> control functions within imx.c. These are used for RS485 line
> driver enable signalling. Having an out-of-date value in the cached
> mctrl can result in the transmitter being enabled when it shouldn't
> be.
> 
> Fix this by updating the mctrl value before applying it.
> 
> Cc: Uwe-Kleine König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> Signed-off-by: Ian Jamison <ian.dev@xxxxxxxxxx>
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Tested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

(I don't know if gregkh takes out my Cc: above (or all?), but if it's
kept I'd like to have the position of - fixed in my name.)

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux