On Wed, 2017-06-28 at 12:52 +0100, Phil Elwell wrote:
> On 28/06/2017 11:57, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Wed, Jun 28, 2017 at 10:41:25AM +0100, Phil Elwell wrote:
> > > Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>
> > > Acked-by: Eric Anholt <eric@xxxxxxxxxx>
> > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > > Changes in v2:
> > > Add review tags.
> >
> > nitpick: The order of lines in the Sob area matter and you should
> > add
> > your Sob at the end. So as it was you adding the ack by Eric and
> > Andy,
> > it should look as follows:
> >
> > Acked-by: Eric Anholt <eric@xxxxxxxxxx>
> > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>
>
> Really? I thought the submitter went first and the final merger went
> last, with other reviewers in-between, like this:
There is a difference between two, i.e. who has added tags in your case
and below one? I guess whoever adds them, adds before their own SoB tag.
>
> commit 6df765dca378bddf994cfd2044acafa501bd800f
> Author: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Date: Wed May 24 21:38:46 2017 +0200
>
> serial: imx: ensure UCR3 and UFCR are setup correctly
>
> [...]
>
> Fixes: e61c38d85b73 ("serial: imx: setup DCEDTE early and
> ensure DCD and RI irqs to be off")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.d
> e>
> Acked-by: Mika Penttilä <mika.penttila@xxxxxxxxxxxx>
> Tested-by: Mika Penttilä <mika.penttila@xxxxxxxxxxxx>
> Acked-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> Tested-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> > . Note that this comment is very picky, quite some people don't get
> > it
> > right and I never saw a maintainer refuse a patch because of this.
> > So
> > this probably doesn't warrant a v3 :-)
> >
> > Best regards
> > Uwe
> >
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
