Hello, On Wed, Jun 28, 2017 at 10:41:25AM +0100, Phil Elwell wrote: > Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx> > Acked-by: Eric Anholt <eric@xxxxxxxxxx> > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > Changes in v2: > Add review tags. nitpick: The order of lines in the Sob area matter and you should add your Sob at the end. So as it was you adding the ack by Eric and Andy, it should look as follows: Acked-by: Eric Anholt <eric@xxxxxxxxxx> Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx> . Note that this comment is very picky, quite some people don't get it right and I never saw a maintainer refuse a patch because of this. So this probably doesn't warrant a v3 :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
