Re: [PATCH v1 1/1] serial: 8250_lpss: enable MSI for sure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-10-11 at 07:08 +0100, deckard wrote:
> On Mon, 2016-10-10 at 11:13 +0300, Andy Shevchenko wrote:
> > The commit 4fe0d154880b ("PCI: Use positive flags in
> > pci_alloc_irq_vectors()")
> > replaces flags from negative to positive values which makes
> > mandatory
> > to have
> > the last argument in pci_alloc_irq_vectors() non-zero (if we want to
> > be no-op).
> > This basically drops MSI enabling in 8250_lpss driver.
> > 
> > Restore desired behaviour in 8250_lpss by passing PCI_IRQ_ALL_TYPES
> > instead of
> > 0 to pci_alloc_irq_vectors().
> > 
> > Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable MSI for Intel
> > Quark")
> > Cc: Christoph Hellwig <hch@xxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>


> Looks good
> 
> Reviewed-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx>

Thanks!

Greg, can you apply this for next v4.9-rcX since without this patch user
loses an ability to use serial console in v4.9-rc1.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux